Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lockfile as an explicit dependency #7169

Merged
merged 3 commits into from
Dec 11, 2022
Merged

Add lockfile as an explicit dependency #7169

merged 3 commits into from
Dec 11, 2022

Conversation

orf
Copy link
Contributor

@orf orf commented Dec 10, 2022

Resolves #7171

Whilst exploring why Homebrew/homebrew-core#117779 is failing, I saw the following traceback:

  File "/usr/local/Cellar/poetry/1.3.0/libexec/lib/python3.11/site-packages/poetry/puzzle/provider.py", line 37, in <module>
    from poetry.vcs.git import Git
  File "/usr/local/Cellar/poetry/1.3.0/libexec/lib/python3.11/site-packages/poetry/vcs/git/__init__.py", line 3, in <module>
    from poetry.vcs.git.backend import Git
  File "/usr/local/Cellar/poetry/1.3.0/libexec/lib/python3.11/site-packages/poetry/vcs/git/backend.py", line 21, in <module>
    from poetry.utils.authenticator import get_default_authenticator
  File "/usr/local/Cellar/poetry/1.3.0/libexec/lib/python3.11/site-packages/poetry/utils/authenticator.py", line 15, in <module>
    import lockfile
ModuleNotFoundError: No module named 'lockfile'

The lockfile module was missing from the resources block when it should have been present. However, Poetry is using the lockfile package directly despite it being brought in via an transient dependency:

This MR adds it as a direct dependency.

pyproject.toml Outdated Show resolved Hide resolved
lazka added a commit to msys2/MINGW-packages that referenced this pull request Dec 10, 2022
@radoering radoering added impact/backport Requires backport to stable branch backport/1.3 labels Dec 11, 2022
@radoering radoering merged commit e4dad22 into python-poetry:master Dec 11, 2022
poetry-bot bot pushed a commit that referenced this pull request Dec 11, 2022
radoering pushed a commit that referenced this pull request Dec 11, 2022
@orf orf deleted the add-explicit-dep branch December 11, 2022 13:01
@sdpkjc sdpkjc mentioned this pull request Jun 5, 2023
18 tasks
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
impact/backport Requires backport to stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency lockfile seemingly missing in 1.3.0
3 participants